Removed a wrong assert. #16170
Closed
Removed a wrong assert. #16170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
shergin
suggested changes
Oct 2, 2017
|
Hey @shergin , I've updated the PR. I checked that I see the log message (and not a crash) in my sample app. FYI, there are several places in RCTUIManager.m with the same RCTAssert : I haven't touched them now, because I am not sure whether those are also bugs. My gut feeling is that most of those should be also only warnings. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 2, 2017
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I agree, it should be special internal method (something like |
StevenLambion
pushed a commit
to StevenLambion/react-native
that referenced
this pull request
Oct 13, 2017
Summary: This fixes [facebook#15801](facebook#15801) We ran into a strange crash on iOS (debug only). After removing the clutter I was able to reproduce it in a tiny app. You can check it out [here.](https://github.com/simonracz/textinput_stress) The UI in JS and native are not always in sync (which is okay). Due to this, a native view might call back into JS, which is no longer present in the shadow view hierarchy there. I think this should be also okay. TextInput in some cases calls into [setIntrinsicContentView](https://github.com/facebook/react-native/blob/6d67e2dbbcd658b7f845ebb0d0156bd64dc68226/React/Modules/RCTUIManager.m#L382), where it triggers an overly enthusiastic `NSAssert` and crashes the app. Check out [textinput_stress](https://github.com/simonracz/textinput_stress) Rotate the simulator a few times to see the crash or the lack of crash. Closes facebook#16170 Differential Revision: D5959776 Pulled By: shergin fbshipit-source-id: f39f5a3f1d86b330ecf7cbccd90871bc01fd69d9
StevenLambion
pushed a commit
to StevenLambion/react-native
that referenced
this pull request
Oct 13, 2017
Summary: This fixes [facebook#15801](facebook#15801) We ran into a strange crash on iOS (debug only). After removing the clutter I was able to reproduce it in a tiny app. You can check it out [here.](https://github.com/simonracz/textinput_stress) The UI in JS and native are not always in sync (which is okay). Due to this, a native view might call back into JS, which is no longer present in the shadow view hierarchy there. I think this should be also okay. TextInput in some cases calls into [setIntrinsicContentView](https://github.com/facebook/react-native/blob/6d67e2dbbcd658b7f845ebb0d0156bd64dc68226/React/Modules/RCTUIManager.m#L382), where it triggers an overly enthusiastic `NSAssert` and crashes the app. Check out [textinput_stress](https://github.com/simonracz/textinput_stress) Rotate the simulator a few times to see the crash or the lack of crash. Closes facebook#16170 Differential Revision: D5959776 Pulled By: shergin fbshipit-source-id: f39f5a3f1d86b330ecf7cbccd90871bc01fd69d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15801
We ran into a strange crash on iOS (debug only). After removing the clutter I was able to reproduce it in a tiny app. You can check it out here.
The UI in JS and native are not always in sync (which is okay). Due to this, a native view might call back into JS, which is no longer present in the shadow view hierarchy there. I think this should be also okay.
TextInput in some cases calls into setIntrinsicContentView, where it triggers an overly enthusiastic
NSAssertand crashes the app.Test Plan
Check out textinput_stress
Rotate the simulator a few times to see the crash or the lack of crash.