[CI] Fix Android Sanity Buck version check #18311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
hehe, I assume this is what you asked me to do in #18303 and I updated the docs instead :D |
|
@vonovak thanks for updating the docs! Thanks to your issue, I'll look a bit more into updating these scripts to provide more feedback to the user. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Mar 10, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: [GENERAL] [MINOR] [./scripts/validate-android-test-env.sh] - Fix buck version check Closes facebook#18311 Differential Revision: D7227452 Pulled By: hramos fbshipit-source-id: c7b32afc36821fbb2462317581ae32d3b257de03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[GENERAL] [MINOR] [./scripts/validate-android-test-env.sh] - Fix buck version check