-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not override metro.config.js
settings
#20705
Conversation
React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native.
Moving `hasteImplModulePath` into `resolver` config. This combined with facebook/react-native#20705 will resolve issues for RN 0.57.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was closed by @rozele in c5297c7. Once this commit is added to a release, you will see the corresponding version tag below the description at c5297c7. If the commit has a single |
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: #20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: facebook#20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: facebook/react-native#20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: facebook#20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
React Native overrides the
metro.config.js
settings for, e.g.,hasteImplModulePath
, which prevents us from adding ametro.config.js
file to the repo forreact-native-windows
to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has ametro.config.js
file, those settings are not overwritten by React Native.Test Plan:
Run
npm test
, also confirmed that this change allows me to set a differenthasteImplModulePath
forreact-native-windows
.Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CATEGORY] [TYPE] [LOCATION] - Message
[GENERAL][CLI][local-cli/core/index.js] - Do not override
metro.config.js
settings