Extracting Platform Specific TM code to break dependency cycle between ReactCommon and React-Core #36461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesIOS` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesIOS` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 4790395850a0f5eca5b5d8ec4b1c640e6e079ec4
cipolleschi
force-pushed
the
export-D44023865
branch
from
fa86f96
to
4ea830b
Compare
Base commit: 803bb16 |
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesIOS` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesIOS` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 63b20ba70e4fe83436cbd49fb6582c9cc495e5f4
cipolleschi
force-pushed
the
export-D44023865
branch
from
4ea830b
to
8831f2d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 38e267504fb602ffa5ff9baa6ed9618b1dea55de
cipolleschi
force-pushed
the
export-D44023865
branch
from
8831f2d
to
1bda114
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 1e76dc840476333453481c439d72ff6044fcfdc0
cipolleschi
force-pushed
the
export-D44023865
branch
from
1bda114
to
ebf94e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: c4fe26842c48533253e344c97d8e98cd3b5d958a
cipolleschi
force-pushed
the
export-D44023865
branch
from
ebf94e6
to
8ac7edc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: db8fb1d79589b6ae8b20f7ea7be25387d231e305
cipolleschi
force-pushed
the
export-D44023865
branch
from
8ac7edc
to
d000638
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: bfb9bf859c7101be745a2b67c9216c9b471c654a
cipolleschi
force-pushed
the
export-D44023865
branch
from
d000638
to
8eef6f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 60c48a7ddc12911c979bd7867122d9cb4a9a9894
cipolleschi
force-pushed
the
export-D44023865
branch
from
8eef6f5
to
37a19c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 5567fb5e536600792a438624e2abfbcdd1f2d81c
cipolleschi
force-pushed
the
export-D44023865
branch
from
37a19c3
to
1ea4e94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 416445e19b5a32abb76480bc13ce48ed2473248c
cipolleschi
force-pushed
the
export-D44023865
branch
from
1ea4e94
to
c079361
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: d1709820a806c59199d04380c4ca958e5b05b1b6
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
force-pushed
the
export-D44023865
branch
from
c079361
to
287a539
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: 7cff6825c90f061e00610c88e1c8f3b5a85fe58c
cipolleschi
force-pushed
the
export-D44023865
branch
from
287a539
to
1f6e52b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 13, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Differential Revision: D44023865 fbshipit-source-id: b85a36b65072043f5ffbcd1d58ab29107c462cf0
cipolleschi
force-pushed
the
export-D44023865
branch
from
1f6e52b
to
e4e699b
Compare
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Reviewed By: mdvacca Differential Revision: D44023865 fbshipit-source-id: d7cb460cc762fe9d6911f7f41afc74d49e74fcbf
|
This pull request was exported from Phabricator. Differential Revision: D44023865 |
cipolleschi
force-pushed
the
export-D44023865
branch
from
e4e699b
to
f9be097
Compare
|
This pull request has been merged in 21d5302. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…n ReactCommon and React-Core (facebook#36461) Summary: Pull Request resolved: facebook#36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Reviewed By: mdvacca Differential Revision: D44023865 fbshipit-source-id: a97569506350db5735ac5534b1592471de196cbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change breaks a dependency cycle between
ReactCommonandReact-Core.React-Coredepends onReactCommonto have access to the variousTurboModulenative files.ReactCommondepends onReact-Corebecause the content of thecore/platform/iosfolder and thesamplesfolder needs to access theRCTBridgeand other files in Core.To break the circular dependency, we introduced two new
podspecs:React-NativeModulesIOSfor the content ofcore/platform/ios.ReactCommon-Samplesfor the content of thesamplesfolder.In this way, the new dependencies are linear as
React-NativeModulesIOSandReactCommon-Samplesdepends onReact-CoreandReactCommonandReact-Coreonly depends onReactCommon.While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes.
Changelog:
[iOS][Breaking] - Split the
ReactCommon/react/nativemodule/core/platform/iosandReactCommon/react/nativemodule/samplesin two separate pods to break circular dependencies.Differential Revision: D44023865