Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #632 using relative path instead of absolute path for Image tag #633

Merged
merged 1 commit into from
Apr 3, 2015

Conversation

krazyeom
Copy link
Contributor

@krazyeom krazyeom commented Apr 3, 2015

It cannot see the some images that are using absolute path on the web page,

so I think it should use absolute path.

@sophiebits
Copy link
Contributor

Tricky. This way works on the website (probably), but not when viewing on GitHub…

@meetwudi
Copy link
Contributor

meetwudi commented Apr 3, 2015

@spicyj Maybe react-native/img/EmbeddedAppExample.png works.

@krazyeom
Copy link
Contributor Author

krazyeom commented Apr 3, 2015

@spicyj it's not tricky. MD files in docs folder is using for http://facebook.github.io/react-native/docs/
another md files are using Relative path. ex) LinkingLibraries.md

![](/react-native/img/AddToLibraries.png)
![](/react-native/img/AddToBuildPhases.png)
![](/react-native/img/AddToSearchPaths.png)

@sophiebits
Copy link
Contributor

Sure, okay. Maybe we can find something that works on both later.

sophiebits added a commit that referenced this pull request Apr 3, 2015
Fixed #632 using relative path instead of absolute path for Image tag
@sophiebits sophiebits merged commit 72b9fcc into facebook:master Apr 3, 2015
facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2017
Summary:
This fixes shrinking of elements which are in a non stretch alignment

Fixes #633
Closes facebook/yoga#634

Differential Revision: D5874862

Pulled By: emilsjolander

fbshipit-source-id: 1426aa6b60f6ba42c2be702e6f24cea935ab7acb
facebook-github-bot pushed a commit that referenced this pull request Nov 27, 2017
Summary:
This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour```

Fixes #633
Closes facebook/yoga#635

Differential Revision: D6408037

Pulled By: emilsjolander

fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
bowerman0 pushed a commit to bowerman0/react-native that referenced this pull request Dec 5, 2017
Summary:
This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour```

Fixes facebook#633
Closes facebook/yoga#635

Differential Revision: D6408037

Pulled By: emilsjolander

fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
bowerman0 pushed a commit to bowerman0/react-native that referenced this pull request Dec 5, 2017
Summary:
This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour```

Fixes facebook#633
Closes facebook/yoga#635

Differential Revision: D6408037

Pulled By: emilsjolander

fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
* [DOCS] autoCapitalize caveat for name-phone-pad

https://developer.apple.com/documentation/uikit/uikeyboardtype/namephonepad

> UIKeyboardType.namePhonePad specifies a keypad designed for entering a person’s name or phone number. This keyboard type does not support auto-capitalization.

* Update textinput.md
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Jan 16, 2021
* merge macos/ios linking to include undefined symbols

* clean up some comments

* reverse platform compiling for macos code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants