Allow forwardRef to be composed with pure #13897
Closed
+181
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
React: size: 🔺+1.9%, gzip: 🔺+1.2% ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.1% Details of bundled changes.Comparing: fa65c58...c19335b react
react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
scheduler
Generated by 🚫 dangerJS |
This uses a different approach than the moddable approach because that approach also started getting quite complex and affects tags and symbols. This way we don't affect the perf of pure and when we drop forwardRef we can just drop this path. This also handles the composition of multiple pure wrappers with custom comparisons.
sebmarkbage
force-pushed
the
composeforwardref
branch
from
9f19059
to
c19335b
Compare
sophiebits
approved these changes
Oct 19, 2018
Merged
|
Superseded by #13903 which is better since it allows any type to be passed to pure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a different approach than the moddable approach because that approach also started getting quite complex and affects tags and symbols.
Instead, I just add a
comparefield to forwardRef's element type and useundefinedto represent the lack of pure wrapper and null to represent the default.This way we don't affect the perf of pure and when we drop forwardRef we can just drop this path.
This also handles the composition of multiple pure wrappers with custom comparisons.