Include full error messages in React Native build #15363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The React Native build does not minify error messages in production, but it still needs to run the error messages transform to compile `invariant` calls to `ReactError`. To do this, I added a `noMinify` option to the Babel plugin. I also renamed it from `minify-error-messages` to the more generic `transform-error-messages`.
elicwhite
reviewed
Apr 9, 2019
| exports[`error transform should support noMinify option 1`] = ` | ||
| "import _ReactError from 'shared/ReactError'; | ||
|
|
||
| import invariant from 'shared/invariant'; |
There was a problem hiding this comment.
Is this supposed to remove the import or does some other dead code elimination step do that?
There was a problem hiding this comment.
Yeah that happens in a subsequent step of the Rollup script
elicwhite
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React Native build does not minify error messages in production, but it still needs to run the error messages transform to compile
invariantcalls toReactError. To do this, I added anoMinifyoption to the Babel plugin. I also renamed it fromminify-error-messagesto the more generictransform-error-messages.