Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update useEditableValue hook to sync external value changes #16878

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Update useEditableValue hook to sync external value changes #16878

merged 3 commits into from
Sep 25, 2019

Commits on Sep 25, 2019

  1. Update useEditableValue to mirror value cahnges 

    Previously, the hook initialized local state (in useState) to mirror the prop/state value. Updates to the value were ignored though. (Once the state was initialized, it was never updated.) The new hook updates the local/editable state to mirror the external value unless there are already pending, local edits being made.
    Brian Vaughn committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    a580a8b View commit details
    Browse the repository at this point in the history

  2. Optimistic CHANGELOG update

    Brian Vaughn committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    fef22e7 View commit details
    Browse the repository at this point in the history

  3. Added additional useEditableValue() unit test cases

    Brian Vaughn committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    5ff6c1c View commit details
    Browse the repository at this point in the history