Remove Blocks #20138
Merged
Remove Blocks #20138
+39
−1,627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
reviewed
Oct 31, 2020
| }); | ||
|
|
||
| // @gate experimental | ||
| it('renders a simple component', () => { |
There was a problem hiding this comment.
Nothing worth converting here?
There was a problem hiding this comment.
I don't think so. These are all just "client blocks" which is just components.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ff6225:
|
There's no need for this now that the JSResource is part of the bundler protocol. Might need something for Webpack plugin specifically later.
Details of bundled changes.Comparing: 3fbd47b...9ff6225 react
react-dom
react-transport-dom-webpack
react-reconciler
react-art
react-test-renderer
react-transport-dom-relay
react-server
react-native-renderer
react-client
ReactDOM: size: 0.0%, gzip: 0.0% React: size: -2.4%, gzip: -1.6% Size changes (experimental) |
Details of bundled changes.Comparing: 3fbd47b...9ff6225 react
react-dom
react-transport-dom-webpack
react-reconciler
react-art
react-native-renderer
react-test-renderer
react-transport-dom-relay
react-server
react-client
Size changes (stable) |
|
End of an era. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 9, 2020
Summary: Base sync before adding Flight files. This sync includes the following changes: - **[454c2211c](facebook/react@454c2211c )**: Refactor SchedulerHostConfigs ([#20025](facebook/react#20025)) //<Ricky>// - **[56e9feead](facebook/react@56e9feead )**: Remove Blocks ([#20138](facebook/react#20138)) //<Sebastian Markbåge>// - **[3fbd47b86](facebook/react@3fbd47b86 )**: Serialize pending server components by reference (lazy component) ([#20137](facebook/react#20137)) //<Sebastian Markbåge>// - **[930ce7c15](facebook/react@930ce7c15 )**: Allow values to be encoded by "reference" to a value rather than the value itself ([#20136](facebook/react#20136)) //<Sebastian Markbåge>// - **[39eb6d176](facebook/react@39eb6d176 )**: Rename ([#20134](facebook/react#20134)) //<Sebastian Markbåge>// - **[ffd842335](facebook/react@ffd842335 )**: [Flight] Add support for Module References in transport protocol ([#20121](facebook/react#20121)) //<Sebastian Markbåge>// - **[343d7a4a7](facebook/react@343d7a4a7 )**: Fast Refresh: Don't block DevTools commit hook ([#20129](facebook/react#20129)) //<Brian Vaughn>// - **[779a472b0](facebook/react@779a472b0 )**: Prevent inlining into recursive commit functions ([#20105](facebook/react#20105)) //<Andrew Clark>// - **[25b18d31c](facebook/react@25b18d31c )**: Traverse commit phase effects iteratively ([#20094](facebook/react#20094)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 4e5d7fa...454c221 Reviewed By: rickhanlonii Differential Revision: D24698701 fbshipit-source-id: dfaf692b1051150355dece1657764a484b7ae603
bvaughn
reviewed
Nov 20, 2020
| @@ -188,7 +187,7 @@ export function getInternalReactConstants( | |||
| LazyComponent: 16, | |||
| MemoComponent: 14, | |||
| Mode: 8, | |||
| OffscreenComponent: 23, // Experimental | |||
| OffscreenComponent: 22, // Experimental | |||
There was a problem hiding this comment.
This change looks wrong. OffscreenComponent is 22 in master now, but in 17.0.0 and 17.0.1 it's 23.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Remove Blocks * Remove Flight Server Runtime There's no need for this now that the JSResource is part of the bundler protocol. Might need something for Webpack plugin specifically later. * Devtools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concept was replaced by server components, so we don't need any of this anymore.