Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WritableFileWriter to allow operation after failure when SyncWithoutFlush() is involved #10555

Closed
wants to merge 2 commits into from
Closed

WritableFileWriter to allow operation after failure when SyncWithoutFlush() is involved #10555

wants to merge 2 commits into from

Commits on Aug 23, 2022

  1. WritableFileWriter to allow operation after failure when SyncWithoutF… 

    …lush() is involved

Summary:
facebook#10489 adds an assertion in most functions in WritableFileWriter to check no previous error. However, it only works without calling SyncWithoutFlush(). The nature of SyncWithoutFlush() makes two concurrent call fails to check status code of each other and causing assertion failure. Fix the problem by skipping the check after SyncWithoutFlush() is called and not check status code in SyncWithoutFlush().

Since the original change was not officially released yet, the fix isn't added to HISTORY.md.

Test Plan: Make sure existing tests still pass
    @siying
    siying committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    8b9b1c8 View commit details
    Browse the repository at this point in the history

  2. initialize parameter.

    @siying
    siying committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    527eea6 View commit details
    Browse the repository at this point in the history