This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
[cargo-compare] fix proptests #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable shadowing, whoops. This wasn't covered in CI because we weren't running our proptests properly. That's covered in facebookarchive#145.
sunshowers
force-pushed
the
cargo-compare-fix
branch
from
adb8040
to
b408af1
Compare
This is how `cargo` behaves, so we should match this behavior.
Whoops, we weren't checking if the test actually failed.
sunshowers
force-pushed
the
cargo-compare-fix
branch
from
b408af1
to
55625f1
Compare
sunshowers
added a commit
that referenced
this pull request
Jun 3, 2020
Variable shadowing, whoops. This wasn't covered in CI because we weren't running our proptests properly. That's covered in #145.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops, we weren't checking if the test actually failed.
Note that this found at least one issue in cargo's v2 resolver (rust-lang/cargo#8312). Can't land until the issue is fixed, and it may find more.