Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] enforce code coverage #37

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[chore] enforce code coverage #37

merged 2 commits into from
Aug 14, 2020

Conversation

msbaines
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2020
Copy link
Contributor

@min-xu-ai min-xu-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files          35       35           
  Lines        2006     2006           
=======================================
  Hits         1887     1887           
  Misses        119      119           
Flag Coverage Δ
#Python 94.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f638e5...f918edb. Read the comment docs.

@msbaines msbaines merged commit fffd3c7 into master Aug 14, 2020
@msbaines msbaines deleted the coverage branch August 14, 2020 03:45
myleott pushed a commit that referenced this pull request Feb 22, 2021
* [mypy]: fixed all the mypy errors

* make older version python happy with typing hints

* [chore] Fix lint errors that broke master (#348)

authored-by: Anjali Sridhar <anj@devfair0443.h2.fair>

Co-authored-by: anj-s <32556631+anj-s@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants