Add default job tab setting #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This commit adds a new setting for the default job tab in the SettingsModal component. The selected default job tab is stored in the useSettingsStore and can be changed by the user.
|
Hi, thank you for this PR! |
felixmosh
reviewed
Jan 22, 2024
Hi, thanks for your quick reply! I pushed changes suggested by you. Will be waiting your review. |
|
Thank you for you contribution 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @felixmosh! First of all, thank you for this amazing tool! We use it everyday and really enjoy it. This is my first PR on this project, would love to get any feedback from you and hope it will be useful for other users as well 🙏
In our project, we were required to implement this feature #264. So basically, we want to have "logs" tab to be opened by default.
To make the solution more flexible I decided to create setting default-job-tab which is used for selecting initial job tab.
Screens:
Todos:
Description:
This commit adds a new setting for the default job tab in the SettingsModal component. The selected default job tab is stored in the useSettingsStore and can be changed by the user.