Prevent exception from Whoops when caught exception frame is not related to real file #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is a fix for #598 would be great to have a unit-test covering the change. @lcharette can you verify the fix? |
|
Yes, seems to be a fix for #598 :)
Done |
SilverFire
changed the title
SilverFire
changed the title
staabm
reviewed
Oct 22, 2018
| */ | ||
| public function testGetFileContentsWhenFrameIsNotRelatedToSpecificFile($fakeFilename) | ||
| { | ||
| $data = array_merge($this->getFrameData(), ['file' => $fakeFilename]); |
There was a problem hiding this comment.
I guess we need php 5.x compat here
Suggested change
| $data = array_merge($this->getFrameData(), ['file' => $fakeFilename]); | |
| $data = array_merge($this->getFrameData(), array('file' => $fakeFilename)); |
There was a problem hiding this comment.
FYI, since you require php 5.5.9 or above, you should be fine.
Following [] is supported in PHP >= 5.4:
|
Looks like it would indeed fix #598. I'll be able to test later today. |
|
I can confirm this PR fix my issue in #598 |
2.3.0 has sailed, this will be in another release.
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.