Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read-only option for rootfs #74

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add read-only option for rootfs #74

merged 1 commit into from
Feb 17, 2022

Conversation

Zamony
Copy link
Contributor

@Zamony Zamony commented Oct 28, 2021

Issue #, if available:

Description of changes:
Add read-only option for root filesystem

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

options.go Outdated
Comment on lines 281 to 290
var newPath string
readOnly := false
if strings.HasSuffix(path, roDeviceSuffix) {
newPath = strings.TrimSuffix(path, roDeviceSuffix)
readOnly = true
} else {
newPath = strings.TrimSuffix(path, rwDeviceSuffix)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about extracting this block? We could have something like newPath, readonly := parseDevice(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kzys thanks! Updated code

@Kern--
Copy link
Contributor

Kern-- commented Nov 1, 2021

Hi @Zamony, Thanks for the PR!

Before this can be merged, it will need a sign off in each of your commit messages like:

Signed-off-by: Full Name

You can do this by committing with git commit -s. Please be sure git is configured to use your real name.

For more info: https://wiki.linuxfoundation.org/dco

Signed-off-by: Nikita Mochalov <mochalov.n@yandex.ru>
@Zamony
Copy link
Contributor Author

Zamony commented Nov 4, 2021

Hi @Zamony, Thanks for the PR!

Before this can be merged, it will need a sign off in each of your commit messages like:

Signed-off-by: Full Name

You can do this by committing with git commit -s. Please be sure git is configured to use your real name.

For more info: https://wiki.linuxfoundation.org/dco

Hi @Kern--. I've signed off the commit.

@Kern-- Kern-- merged commit f0e391f into firecracker-microvm:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants