adding subscription_id in invoice table for use in the main stripe pa… #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
added
enhancement
fivetran-joemarkiewicz
requested changes
Jun 13, 2022
There was a problem hiding this comment.
@ashishk-de thanks so much for opening this PR 🙌
I apologize for the delayed response in giving this a review. I just took a look and this enhancement seems like a more than reasonable addition to the package. Before we progress with merging this to main and including in the next release, I did have a few requested updates:
- With the new field being added to the staging model, we should also update the
src_stripe.ymlandstg_stripe.ymlfiles to include the new field within the dbt documentation. - Make the same version increase adjustment that you made in the
dbt_project.ymlfile within theintegration_test/dbt_project.ymlfile.
Once those small changes are applied, we should be good to go! Let me know if you have any questions 😄
|
This has been merged with #45 |
|
closing as this was merged with another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckage
Pull Request
Are you a current Fivetran customer?
yes. Abine Inc
What change(s) does this PR introduce?
Adds subscription_id to invoice table.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
My stripe instance uses subscription. I am unsure if the Invoice object from stripe will always have the subscription_id column available based on your usage of subscriptions feature in stripe.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.