-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support resetting TileLayer #667
Conversation
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Any news? |
@JaffaKetchup, I can bring this PR inline with master this weekend if required. I haven't looked at this in a few months |
Don't worry about it, it would just be nice to have, and improve the experience of my plugin especially. |
@tprebs would be great! |
@tprebs If you're busy, I can bring it up to date now for you? |
I would love to have this merged! |
Don't like to ask again, but any hope of this coming soon? @tprebs |
@JaffaKetchup sorry for the delay, it's been a busy couple of months. I have brought the PR up to master. I have also been planning on making the feaflet heatmap plugin available but there are just not enough hours in the day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
@tprebs Thanks, and don't worry about the delay, it's similar story for me. Great that you've finally found time to do it! |
Yes, I'm not allowed to approve my own PRs, so we need to wait on @johnpryan or some of the other contributors with write access to master. |
This change supports the clearing of in memory tiles from the TileLayerState as described in #666
I created a separate Stream to manage reset events instead of using the LayerOptions rebuild stream as this is currently consumed by the onMove event subscriber and any changes to this may affect existing implementations using the rebuild.
I have also added an example for resetting the a TileLayer