Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support resetting TileLayer #667

Merged
merged 2 commits into from
Sep 3, 2021
Merged

feat: support resetting TileLayer #667

merged 2 commits into from
Sep 3, 2021

Conversation

tprebs
Copy link

@tprebs tprebs commented Jun 23, 2020

This change supports the clearing of in memory tiles from the TileLayerState as described in #666

I created a separate Stream to manage reset events instead of using the LayerOptions rebuild stream as this is currently consumed by the onMove event subscriber and any changes to this may affect existing implementations using the rebuild.

I have also added an example for resetting the a TileLayer

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 21, 2021
@JaffaKetchup
Copy link
Member

Any news?

@tprebs
Copy link
Author

tprebs commented Jul 20, 2021

@JaffaKetchup, I can bring this PR inline with master this weekend if required. I haven't looked at this in a few months

@JaffaKetchup
Copy link
Member

Don't worry about it, it would just be nice to have, and improve the experience of my plugin especially.

@JaffaKetchup JaffaKetchup mentioned this pull request Jul 28, 2021
@antonshkurenko
Copy link

@tprebs would be great!

@JaffaKetchup
Copy link
Member

@tprebs If you're busy, I can bring it up to date now for you?

@antonshkurenko
Copy link

I would love to have this merged!

@JaffaKetchup
Copy link
Member

Don't like to ask again, but any hope of this coming soon? @tprebs

@tprebs
Copy link
Author

tprebs commented Sep 3, 2021

@JaffaKetchup sorry for the delay, it's been a busy couple of months. I have brought the PR up to master. I have also been planning on making the feaflet heatmap plugin available but there are just not enough hours in the day

Copy link
Contributor

@kengu kengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@JaffaKetchup
Copy link
Member

@tprebs Thanks, and don't worry about the delay, it's similar story for me. Great that you've finally found time to do it!

@kengu kengu merged commit 27235cd into fleaflet:master Sep 3, 2021
@JaffaKetchup
Copy link
Member

@kengu Thanks for all the merges today :), is there a pub.dev update planned any time soon to publish these changes?

PS. You haven't merged #989, correct me if I'm wrong, but I'm assuming you need another maintainers approval as it was originally written by you?

@kengu
Copy link
Contributor

kengu commented Sep 3, 2021

Yes, I'm not allowed to approve my own PRs, so we need to wait on @johnpryan or some of the other contributors with write access to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants