crypto.pbkdf2 with digest param

[aegyed91]

Hi @florianheinemann,

i recently updated to node.js v6.0.0 and i see (node:21314) DeprecationWarning: crypto.pbkdf2 without specifying a digest is deprecated. Please specify a digest.

By specifying a digest parameter this log goes away.

[aegyed91]

pbkdf2 digest overloading is deprecated #4047

https://nodejs.org/en/blog/release/v6.0.0/?utm_source=nodeweekly&utm_medium=email#notable-changes

[florianheinemann]

Hi!

Thanks for the PR! Before fixing the digest to sha512 - I believe it would be great to check if this is the most appropriate one and if this will run on most systems. Also: We might want to leave the option for people to overwrite the default digest.

Any thoughts?

Cheers

[aegyed91]

Hi, no problem

i assume whichever digest you go with, it should be working fine on all OS

actually if we choose that path then the iteration number and the keylen could be overridden too. But then you will need to override those options in the verifyAgainst method too.

one more thing, check this out. this is your script rewritten

i think an api like this would be better:

hashPassword(password, [salt], [options])
verifyPassword(password, hashedPassword, [options])

and it should return a promise if you dont specify a callback, with bluebird's .asCallback maybe or without bluebird as a dep. But it is a lot more effective than the native promise implementation

[florianheinemann]

See #7 Thank you!