Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new path for fluent-package #500

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Use new path for fluent-package #500

merged 2 commits into from
Jun 19, 2023

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jun 14, 2023

No need to use old path for fluent-package.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 14, 2023

Need to rebase with #499

No need to use old path for fluent-package.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys
Copy link
Contributor Author

kenhys commented Jun 14, 2023

failure on focal and jammy. checking....

@kenhys
Copy link
Contributor Author

kenhys commented Jun 14, 2023

Hmm, postinst hook may not work as expected 🤔

@daipom
Copy link
Contributor

daipom commented Jun 14, 2023

It sometimes fails in other PRs as well. (#501)

Is it possible that #489 (comment) problem still remains?

@kenhys
Copy link
Contributor Author

kenhys commented Jun 16, 2023

Is it possible that #489 (comment) problem still remains?

There is a possibility of it. checking...

On local VM, update-from-v4.sh will succeed. 🤔

@kenhys
Copy link
Contributor Author

kenhys commented Jun 16, 2023

Try to run the failed job again.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 16, 2023

I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet)
maybe waiting appropriate time will work. 🤔

@kenhys kenhys marked this pull request as ready for review June 16, 2023 09:30
@daipom
Copy link
Contributor

daipom commented Jun 16, 2023

I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet) maybe waiting appropriate time will work. thinking

I wonder if this is the real cause of this problem.

I have tested the following 2 patterns on my local.

  • Add sleep 3 before systemctl status check like this PR.
  • Add --wait option to systemctl status check.

However, both patterns fail about 1 in 3 times.

It may be a good idea to add sleep or --wait option just in case, but perhaps it has nothing to do with this problem.

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran tests several times and confirmed they can still fail.
However, I think it has nothing to do with this PR.

This PR looks good to me.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 19, 2023

However, both patterns fail about 1 in 3 times.

Thank you for checking.
I'll investigate it again.

Anyway, using --wait option is better, I'll fix it.

It seems that it is more safe to wait some extent to sync.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys
Copy link
Contributor Author

kenhys commented Jun 19, 2023

changed to use --wait option to sync.

@kenhys kenhys merged commit 7221f3e into fluent:master Jun 19, 2023
@kenhys kenhys deleted the use-new-path branch June 19, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants