-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new path for fluent-package #500
Conversation
Need to rebase with #499 |
No need to use old path for fluent-package. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
failure on focal and jammy. checking.... |
Hmm, postinst hook may not work as expected 🤔 |
It sometimes fails in other PRs as well. (#501) Is it possible that #489 (comment) problem still remains? |
There is a possibility of it. checking... On local VM, update-from-v4.sh will succeed. 🤔 |
Try to run the failed job again. |
I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet) |
I wonder if this is the real cause of this problem. I have tested the following 2 patterns on my local.
However, both patterns fail about 1 in 3 times. It may be a good idea to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran tests several times and confirmed they can still fail.
However, I think it has nothing to do with this PR.
This PR looks good to me.
Thank you for checking. Anyway, using |
It seems that it is more safe to wait some extent to sync. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
changed to use |
No need to use old path for fluent-package.