Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop maintaining multiple copies of the same conf #525

Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jul 17, 2023

Just refactoring. This does not change the result.

Just refactoring. This does not change the result.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom
Copy link
Contributor Author

daipom commented Jul 17, 2023

We need to do some fixes following this.
I will do them after this PR.

I have one question.
Do we still need /opt/fluent/share/td-agent.conf.tmpl?

It is not used after the following PR:

but it is still better to have the default config under the /opt/fluent/share/, right?

@ashie
Copy link
Member

ashie commented Jul 18, 2023

but it is still better to have the default config under the /opt/fluent/share/, right?

I think so.

@daipom
Copy link
Contributor Author

daipom commented Jul 18, 2023

but it is still better to have the default config under the /opt/fluent/share/, right?

I think so.

Thanks!

@ashie ashie requested a review from kenhys July 18, 2023 00:54
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the rest of the work will be done in another PR (#525 (comment)),
it seems a reasonable fix.

@kenhys kenhys merged commit cc87e72 into fluent:master Jul 18, 2023
19 checks passed
@daipom daipom deleted the stop-maintaining-multiple-copies-of-the-same-conf branch July 18, 2023 02:02
@daipom
Copy link
Contributor Author

daipom commented Jul 18, 2023

Thanks for your review!

@daipom
Copy link
Contributor Author

daipom commented Jul 18, 2023

Done all TODO!

#525 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants