Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that excessively block to launch #656

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix a bug that excessively block to launch #656

merged 1 commit into from
Jul 5, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jul 5, 2024

In the previous versions, guard duplicated instance mechanism was introduced.

But it should not block -h/--help and so on because user may refer command line option in such a case.

In the previous versions, guard duplicated instance mechanism
was introduced.

But it should not block -h/--help and so on because user
may refer command line option in such a case.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!

@kenhys kenhys merged commit 3dc81f1 into master Jul 5, 2024
56 checks passed
@kenhys kenhys deleted the allow-help branch July 5, 2024 08:33
@kenhys kenhys added this to the 5.0.4 (T.B.D.) milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants