[Impeller] remove image upload from IO thread, limit concurrent worker threads. #52423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
chinmaygarde
approved these changes
Apr 27, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 28, 2024
…rent worker threads. (flutter/engine#52423)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2024
…147495) flutter/engine@752b146...f4c20e9 2024-04-28 jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423) 2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Apr 29, 2024
…isions) (#147495)" (#147502) Reverts: #147495 Initiated by: zanderso Reason for reverting: Crash in framework CI https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20new_gallery_opengles_impeller__transition_perf/2417/overview Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@752b146...f4c20e9 2024-04-28 jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423) 2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2024
…rent worker threads. (flutter/engine#52423)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 29, 2024
…147532) flutter/engine@752b146...399837d 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from 27e872349963 to f7bfa8eef5b5 (1 revision) (flutter/engine#52436) 2024-04-29 jonahwilliams@google.com [Impeller] fix GLES image upload. (flutter/engine#52430) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from aeab79038011 to 27e872349963 (1 revision) (flutter/engine#52435) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from c720e2446926 to aeab79038011 (1 revision) (flutter/engine#52434) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from 1a5436d50954 to c720e2446926 (1 revision) (flutter/engine#52433) 2024-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bIUvi3y4gRFxMSKV3... to TFm2_qWC2xpkzk8QS... (flutter/engine#52432) 2024-04-29 skia-flutter-autoroll@skia.org Roll Skia from e3dfcd1b25af to 1a5436d50954 (1 revision) (flutter/engine#52431) 2024-04-28 robert.ancell@canonical.com Use a AT-SPI socket/plug to export the Flutter accessibility state. (flutter/engine#52355) 2024-04-28 jonahwilliams@google.com [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423) 2024-04-28 jonahwilliams@google.com [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from bIUvi3y4gRFx to TFm2_qWC2xpk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#123058
Fixes flutter/flutter#135443
We're currently using the IO thread to bottleneck image uploads. Instead, just use fewer concurrent worker threads - and cap the limit at something small. For a Pixel device, this should use about 2 threads maximum, instead of 5 (4 worker and 1 IO).