Skip to content

Commit

Permalink
Exclude abi key in local golden file testing (#148023)
Browse files Browse the repository at this point in the history
Part of #148022
  • Loading branch information
Piinks authored May 8, 2024
1 parent 2603055 commit 00f4066
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion packages/flutter_goldens/lib/skia_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,8 @@ class SkiaGoldClient {
'WebRenderer' : webRenderer,
'CI' : 'luci',
'Platform' : platform.operatingSystem,
'Abi': abi.toString(),
// 'Abi': abi.toString(), workaround for https://g-issues.skia.org/issues/339508268
// Flutter tracking issue: https://github.com/flutter/flutter/issues/148022
'name' : testName,
'source_type' : 'flutter',
if (_isImpeller)
Expand Down
6 changes: 3 additions & 3 deletions packages/flutter_goldens/test/flutter_goldens_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ void main() {

expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('1937c1c93610cc0122a86a83d5bd38a4'),
equals('ae18c7a6aa48e0685525dfe8fdf79003'),
);
});

Expand Down Expand Up @@ -533,7 +533,7 @@ void main() {

expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('bc44a50c01eb3bbaf72a80d76c1c2305'),
equals('e9d5c296c48e7126808520e9cc191243'),
);
});

Expand Down Expand Up @@ -561,7 +561,7 @@ void main() {
);
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('8821f4896801fcdd7cd6d30f5a8e4284'),
equals('9968695b9ae78cdb77cbb2be621ca2d6'),
);
});

Expand Down

0 comments on commit 00f4066

Please sign in to comment.