Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Row and Column widgets specific spacing tests #153352

Closed
TahaTesser opened this issue Aug 13, 2024 · 1 comment · Fixed by #153353
Closed

Missing Row and Column widgets specific spacing tests #153352

TahaTesser opened this issue Aug 13, 2024 · 1 comment · Fixed by #153353
Assignees
@TahaTesser
Labels
a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. r: fixed Issue is closed as already fixed in a newer version team-framework Owned by Framework team

Comments

@TahaTesser
Copy link
Member

TahaTesser commented Aug 13, 2024 •
edited
Loading

Use case

#152890 added spacing parameter to the Flex and passes it tot Row/Column.

During a break, I realized i didn't add Row and Column tests to make sure spacing cannot be removed from these widgets without failing widget specific tests.

Proposal

Add missing tests
@TahaTesser TahaTesser added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter team-framework Owned by Framework team and removed in triage Presently being triaged by the triage team labels Aug 13, 2024
@TahaTesser TahaTesser mentioned this issue Aug 13, 2024
Merged
9 tasks
@TahaTesser TahaTesser self-assigned this Aug 13, 2024
auto-submit bot pushed a commit that referenced this issue Aug 14, 2024
@TahaTesser
Add Row and Column widgets specific spacing tests (#153353)
ed40925 
Fixes [Missing `Row` and `Column` widgets specific `spacing` tests](#153352)
@TahaTesser TahaTesser added the r: fixed Issue is closed as already fixed in a newer version label Aug 14, 2024
DBowen33 pushed a commit to DBowen33/flutter that referenced this issue Aug 16, 2024
@TahaTesser @DBowen33
Add Row and Column widgets specific spacing tests (flutter#153353)
ade90ae 
Fixes [Missing `Row` and `Column` widgets specific `spacing` tests](flutter#153352)
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TahaTesser TahaTesser

Labels
a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. r: fixed Issue is closed as already fixed in a newer version team-framework Owned by Framework team
Projects
Nevercode
Status: Done (PR merged)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Row and Column widgets specific spacing tests TahaTesser/flutter
1 participant
@TahaTesser