[video_player] integration test is very flaky on iOS

[stuartmorgan]

Recently we're having to re-run the build-ipas+drive_examples shard that contains the video_player plugin pretty frequently. I haven't gone back through logs, but I feel like it's been the last week or so where it's been really bad.

Example failing run: https://cirrus-ci.com/task/4561521528274944

flutter: 00:10 +8 ~1 -1: Some tests failed.
Failure Details:
Failure in method: test video player view with local asset
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following TestFailure object was thrown running a test:
  Expected: <true>
  Actual: <false>
When the exception was thrown, this was the stack:
#4      main.<anonymous closure>.<anonymous closure> (file:///private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/video_player/video_player/example/integration_test/video_player_test.dart:222:7)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
  file:///private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/video_player/video_player/example/integration_test/video_player_test.dart line 222
The test description was:
  test video player view with local asset
═════════════════════════════════════════════════════════════════
end of failure 1

[stuartmorgan]

This is definitely still a common source of flake.

The assertion that is failing is: expect(_controller.value.isPlaying, true);.

[flutter-triage-bot]

This issue is marked P1 but has had no recent status updates.

The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

[vashworth]

We should reenable this to see if it's still flaky.

cc @hellohuanlin

[stuartmorgan]

I just saw this flake on Android. Maybe there's an issue with the test design.

Edit: looking at this test again, I don't actually see anything here that waits for it to start. It waits for animation to finish, but I don't see any reason to expect that would happen only after the video has loaded. I'm going to rework this and try re-enabling it.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.