Fix memory leaks in Hero widget [prod-leak-fix]
#147303
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @polina-c |
github-actions
bot
added
the
framework
ValentinVignal
force-pushed
the
flutter/leak-tracking/fix-leaks-in-hero
branch
from
0894631
to
f508433
Compare
polina-c
added
the
a: leak tracking
polina-c
reviewed
Apr 24, 2024
polina-c
approved these changes
Apr 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 26, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 26, 2024
flutter/flutter@5d3bca4...2e80670 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399) 2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372) 2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388) 2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391) 2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312) 2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016) 2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386) 2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378) 2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853) 2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303) 2024-04-25 engine-flutter-autoroll@skia.org Roll Packages from cf6d280 to fde908d (11 revisions) (flutter/flutter#147375) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@5d3bca4...2e80670 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399) 2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372) 2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388) 2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391) 2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312) 2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016) 2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386) 2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378) 2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853) 2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303) 2024-04-25 engine-flutter-autoroll@skia.org Roll Packages from cf6d280 to fde908d (11 revisions) (flutter/flutter#147375) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter/flutter@5d3bca4...2e80670 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399) 2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372) 2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388) 2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370) 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391) 2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312) 2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016) 2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386) 2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378) 2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853) 2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303) 2024-04-25 engine-flutter-autoroll@skia.org Roll Packages from cf6d280 to fde908d (11 revisions) (flutter/flutter#147375) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
polina-c
changed the title
Hero widgetHero widget [prod-leak-fix]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #141198
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.