-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run one build per platform in recipes cq. #5226
Conversation
Flakiness in packages build block recipe changes very frequently and slows them down. Given that the same recipe is used in all the builds we only need to run one build per platform in the cq.
How does that follow? Not every build uses every feature of the recipes. For instance, we need to add secrets support for the maps API keys, and none of the builds chosen here would make use of them. None of these use emulator support either, which IIRC has a recipe component. Shouldn't we have one of each kind of build, and just remove shards beyond shard 1? |
@godofredoc Ping on the question above. |
@godofredoc Should this still be open? |
Recipes CQ is intended to validate changes on recipes and/or recipe modules. Just enough builds to test the packages recipe paths is desirable. Also inspecting the packages recipe seems really flat not sure why we need tens of builds to validate it. The main reason I created this PR is because some of these builds are very slow and fail frequently blocking recipes CLs for several hours. If we would like to continue running all these builds can we at least remove the slow and flaky ones? |
Then we need at least one build using everything the recipe does. E.g., emulators, as I mentioned above. Just one per platform isn't sufficient to test all the recipe functionality.
I'm fine with trimming the list down, but it needs to do so in a way that doesn't remove coverage of critical functionality.
Emulators are only used for integration tests, so there is no way to ensure that emulator support isn't broken without one such test being included. |
@godofredoc How do you want to proceed with this? Do you need me to identify a more minimal set without losing key coverage? |
From triage: I'll update this to a smaller (but less minimal) set. |
Closing in favor of #6673 |
Flakiness in packages build block recipe changes very frequently and slows them down. Given that the same recipe is used in all the builds we only need to run one build per platform in the cq.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.