[go_router_builder] add support to go_router_builder for initializing a StatefulShellBranch with observers #5865
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
or anyone else create PR instead of me, please! 🙏 |
|
Hi @satoyan , thank you for your contribution, can you also add tests to this pr? |
|
Thank you for your replying! I added some test cases and update version to pass CI. |
satoyan
changed the title
|
@johnpryan Hi John, can you take a second look at this since chun-heng is on vacation ? |
johnpryan
approved these changes
Feb 15, 2024
hangyujin
reviewed
Feb 15, 2024
satoyan
force-pushed
the
main
branch
3 times, most recently
from
0799fb1
to
4ea4147
Compare
|
looks like there is a conflict and ci failing, can you fix them? |
add flutter dependency same as go_router to pubspec.yaml as well because test cases added required some type definitions from flutter.
chunhtai
reviewed
Apr 18, 2024
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2024
…itializing a StatefulShellBranch with observers (flutter/packages#5865)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2024
…itializing a StatefulShellBranch with observers (flutter/packages#5865)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2024
flutter/packages@fde908d...dd01140 2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter from 5d3bca4 to 2e80670 (20 revisions) (flutter/packages#6616) 2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.2 to 3.25.3 (flutter/packages#6615) 2024-04-25 elitree@gmail.com [go_router] Update redirect documentation example code for clarity (flutter/packages#6213) 2024-04-25 satoyanxp@gmail.com [go_router_builder] add support to go_router_builder for initializing a StatefulShellBranch with observers (flutter/packages#5865) 2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter from dba4f77 to 5d3bca4 (17 revisions) (flutter/packages#6612) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
… a StatefulShellBranch with observers (flutter#5865) This pr added the ability to provide a list of NavigatorObservers to a StatefulShellBranch. The equivalent was never added to go_router_builder, so this pr provides that functionality. With this change, you can provide NavigatorObservers directly to the StatefulShellBranch and fix flutter/flutter#143869.
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
… a StatefulShellBranch with observers (flutter#5865) This pr added the ability to provide a list of NavigatorObservers to a StatefulShellBranch. The equivalent was never added to go_router_builder, so this pr provides that functionality. With this change, you can provide NavigatorObservers directly to the StatefulShellBranch and fix flutter/flutter#143869.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr added the ability to provide a list of NavigatorObservers to a StatefulShellBranch.
The equivalent was never added to go_router_builder, so this pr provides that functionality.
With this change, you can provide NavigatorObservers directly to the StatefulShellBranch and fix flutter/flutter#143869.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.