-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip podspec Swift Search Path validation if only swift file is Package.swift for darwin plugins #6635
Merged
auto-submit
merged 2 commits into
flutter:main
from
vashworth:darwin_swift_package_podspec_validation
May 2, 2024
Merged
Skip podspec Swift Search Path validation if only swift file is Package.swift for darwin plugins #6635
auto-submit
merged 2 commits into
flutter:main
from
vashworth:darwin_swift_package_podspec_validation
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge.swift for darwin plugins
stuartmorgan
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vashworth
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
May 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2024
…e is Package.swift for darwin plugins (flutter/packages#6635)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2024
flutter/packages@aea93d2...f4719ca 2024-05-02 reidbaker@google.com [in_app_purchase] implement countryCode correctly (flutter/packages#6636) 2024-05-02 15619084+vashworth@users.noreply.github.com Skip podspec Swift Search Path validation if only swift file is Package.swift for darwin plugins (flutter/packages#6635) 2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter from d33bb8f to bf7191f (34 revisions) (flutter/packages#6637) 2024-05-01 petermnt@users.noreply.github.com [webview_flutter_android] Fixes iframe navigation with `onNavigationRequest` (flutter/packages#6335) 2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter from b597dd2 to d33bb8f (7 revisions) (flutter/packages#6633) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…ge.swift for darwin plugins (flutter#6635) Fix for iOS was added in flutter#6627, but neglected to handle when plugin uses darwin directory. Supplemental fix for flutter/flutter#147548.
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…ge.swift for darwin plugins (flutter#6635) Fix for iOS was added in flutter#6627, but neglected to handle when plugin uses darwin directory. Supplemental fix for flutter/flutter#147548.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for iOS was added in #6627, but neglected to handle when plugin uses darwin directory.
Supplemental fix for flutter/flutter#147548.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.