Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path_provider] Add Swift Package Manager support #6680

Merged
merged 2 commits into from
May 7, 2024

Conversation

stuartmorgan
Copy link
Contributor

Adds SPM support for iOS and macOS.

No Xcode project changes are included, to maintain compatibility with stable.

Fixes flutter/flutter#146913

Pre-launch Checklist

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor Author

test-exempt: configuration change

(SPM support is automatically tested by CI now that it's enabled.)

Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2024
@auto-submit auto-submit bot merged commit 8de142d into flutter:main May 7, 2024
78 checks passed
@stuartmorgan stuartmorgan deleted the path-provider-spm branch May 7, 2024 20:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 8, 2024
flutter/packages@5ccddfc...8de142d

2024-05-07 stuartmorgan@google.com [path_provider] Add Swift Package Manager support (flutter/packages#6680)
2024-05-07 goderbauer@google.com [go_router] guard context access in then clauses (flutter/packages#6685)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter from 04424e1 to 7920a52 (27 revisions) (flutter/packages#6683)
2024-05-07 srawlins@google.com [camera] Ignore implementation imports outside of lib (flutter/packages#6191)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
Adds SPM support for iOS and macOS.

No Xcode project changes are included, to maintain compatibility with `stable`.

Fixes flutter/flutter#146913
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Adds SPM support for iOS and macOS.

No Xcode project changes are included, to maintain compatibility with `stable`.

Fixes flutter/flutter#146913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: path_provider platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[path_provider_foundation] Add Swift Package Manager compatibility to path_provider_foundation
2 participants