Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview_flutter] Skip "Video playback policy" drive tests #6747

Merged
merged 4 commits into from
May 16, 2024
Merged

[webview_flutter] Skip "Video playback policy" drive tests #6747

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a2553f
Skip 'Video playback policy Auto media playback' drive test
vashworth May 16, 2024
a4ee059
Retrigger tests
vashworth May 16, 2024
cc9e32b
assign TODO
vashworth May 16, 2024
fc0129e
Skip all Video playback policy tests
vashworth May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ Future<void> main() async {
isPaused =
await controller.runJavaScriptReturningResult('isPaused();') as bool;
expect(isPaused, true);
});
},
// TODO(bparrishMines): Stop skipping once https://github.com/flutter/flutter/issues/148487 is resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bparrishMines I assigned the TODO to you as code owner since it wouldn't allow me to leave it empty.

skip: true);

testWidgets('Video plays inline', (WidgetTester tester) async {
final Completer<void> pageLoaded = Completer<void>();
Expand Down