[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests #7571
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
p: extension_google_sign_in_as_googleapis_auth
p: rfw
bparrishMines
changed the title
bparrishMines
changed the title
| @@ -6,7 +6,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:8.1.0' | |||
There was a problem hiding this comment.
@gmackall this change should not be required based on what I know about the reasons for having to update to at least agp 8.1 (androidx unpublished dependency).
Do you know why this update is required?
There was a problem hiding this comment.
I think the upgrade to this example shouldn't be necessary (just the upgrade that landed in https://github.com/flutter/packages/pull/7545/files), but also it doesn't hurt to have them all on the latest
There was a problem hiding this comment.
This wasn't required. I just updated since it was in the same package. I went ahead and reverted it. But I can upgrade if that is preferred.
|
The It seems to be hitting an issue with R8, perhaps something related to flutter/flutter#154489? Still investigating |
bparrishMines
changed the title
@gmackall |
Interesting! If it compiles then it LGTM! |
| @@ -1,3 +1,3 @@ | |||
| org.gradle.jvmargs=-Xmx1536M | |||
There was a problem hiding this comment.
I recall there are actually 2 parameters you need to set here. Let me see if I can find an example.
There was a problem hiding this comment.
I found the commit for this one I think: 0814a3b
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm it builds locally but not on CI
There was a problem hiding this comment.
Ok, this is the same issue as flutter/flutter#154489. It seems like upgrading the guava version in 6.1.25 of google_sign_in_android has caused some issues with our use of R8 (I verified that reverting back to using
implementation 'com.google.guava:guava:32.0.1-android'
makes this example app build successfully).
I think perhaps we should revert back to that guava version to unblock the roller (and also to unblock google_sign_in_android being broken on flutter's latest master), and then investigate what it will take to unblock that upgrade
There was a problem hiding this comment.
Looks like it builds successfully now!
….0.1` (#7573) This upgrade is causing issues with our use of R8. I think we should downgrade back, while we investigate what it takes to unblock this upgrade. Fixes flutter/flutter#154489, related to #7571 (comment).
| @@ -1,3 +1,3 @@ | |||
| org.gradle.jvmargs=-Xmx1536M | |||
There was a problem hiding this comment.
bparrishMines
changed the title
bparrishMines
added
the
autosubmit
…lutter_ios] Manual roll with fixes to example and skipping some native tests (flutter/packages#7571)
flutter/packages@71e827e...56df73e 2024-09-06 10687576+bparrishMines@users.noreply.github.com [extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests (flutter/packages#7571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
It looks like #7521 missed a few packages examples and they are now failing to compile on main.
Some native tests have also began to fail consistently for
google_maps_flutter_ios: flutter/flutter#154641Some legacy iOS
webview_fluttertests were also failing: flutter/flutter#154676Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.