Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-0007] Add --provider flag to flux create source git #4986

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dipti-pai
Copy link
Contributor

  • Add provider flag to flux create source git command with supported values: azure, generic.
  • Unit tests validating the generated yaml with supported provider and error conditions.

internal/flags/source_git_provider.go Outdated Show resolved Hide resolved
internal/flags/source_git_provider.go Outdated Show resolved Hide resolved
cmd/flux/create_source_git.go Show resolved Hide resolved
cmd/flux/create_source_git.go Outdated Show resolved Hide resolved
@darkowlzz darkowlzz added the area/git Git related issues and pull requests label Sep 17, 2024
@stefanprodan stefanprodan mentioned this pull request Sep 24, 2024
57 tasks
- Add provider flag to `flux create source git` command with supported values: azure, generic.

- Unit tests validating the generated yaml and error conditions.

Signed-off-by: Dipti Pai <diptipai89@outlook.com>
@stefanprodan stefanprodan changed the title [RFC-0007] Flux CLI change to add provider field to GitRepository spec. [RFC-0007] Add --provider flag to flux create source git Sep 26, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit e970a2d into fluxcd:main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants