Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC-0006] Add CDEvent Receiver Support #772

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[RFC-0006] Add CDEvent Receiver Support #772

merged 1 commit into from
Mar 27, 2024

Conversation

adamkenihan
Copy link
Contributor

@adamkenihan adamkenihan commented Mar 19, 2024 •
edited by stefanprodan
Loading

Adding CDEvent Receiver implementation according to RFC-0006

Fix: #769

darkowlzz
darkowlzz reviewed Mar 19, 2024
View reviewed changes
internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
internal/server/receiver_handler_test.go Show resolved Hide resolved
internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
@stefanprodan
Copy link
Member

stefanprodan commented Mar 25, 2024 •
edited
Loading

@adamkenihan can you please signoff all your commits, this is a requirement for Flux contributions. Also can you run make test before pushing any commits upstream, by the looks of it, this code does not compile since it imports packages not present in go.mod.

darkowlzz
darkowlzz reviewed Mar 25, 2024
View reviewed changes
docs/spec/v1/receivers.md Outdated Show resolved Hide resolved
internal/server/receiver_handler_test.go Outdated Show resolved Hide resolved
@darkowlzz
Copy link
Contributor

darkowlzz commented Mar 25, 2024 •
edited
Loading

This is almost ready. Please rebase on the latest main branch. I think we'll be able to merge it soon.
And also squash all the commits to one or a few relevant ones.

@darkowlzz
Copy link
Contributor

The git worktree seems to be in a dirty state after running the CI build steps, see https://github.com/fluxcd/notification-controller/actions/runs/8423005933/job/23075692347?pr=772.
You can run make manifests to generate the changes in config/crd/bases/notification.toolkit.fluxcd.io_receivers.yaml and gofmt -w internal/server/receiver_handlers.go or make fmt to fix the formatting issue in receiver_handlers.go.

darkowlzz
darkowlzz approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Left a minor suggestion which can used or ignored.

internal/server/receiver_handlers.go Outdated Show resolved Hide resolved
@darkowlzz darkowlzz added the area/receiver Webhook receiver related issues and PRs label Mar 26, 2024
@adamkenihan
Implement CDEvents Receiver
b4949b6 
Signed-off-by: adamkenihan <adam.kenihan@est.tech>

Added CDEvents Receiver

Signed-off-by: adamkenihan <adam.kenihan@est.tech>

Added CDEvent Validation + Tests

Signed-off-by: adamkenihan <adam.kenihan@est.tech>

Small changes to CDEvent Receiver

Signed-off-by: adamkenihan <adam.kenihan@est.tech>

More CDEvents Tests and Docs added

Signed-off-by: adamkenihan <adam.kenihan@est.tech>

Adding imports to go.mod

Signed-off-by: adamkenihan <adam.kenihan@est.tech>

small changes + manifests and formatting

Signed-off-by: adamkenihan <adam.kenihan@est.tech>

Changing string compare to EqualFold

Signed-off-by: adamkenihan <adam.kenihan@est.tech>
stefanprodan
stefanprodan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @adamkenihan 🥇

@stefanprodan stefanprodan merged commit 17adf69 into fluxcd:main Mar 27, 2024
6 checks passed
@stefanprodan stefanprodan mentioned this pull request Apr 9, 2024
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/receiver Webhook receiver related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC-0006] Implement CDEvents Receiver type
3 participants
@adamkenihan @stefanprodan @darkowlzz