Pass site_config as an optional arg. #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frappeui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bprashanth
force-pushed
the
site_config
branch
from
ef91ce0
to
157aace
Compare
This change passes a path to a site_config into vite.js's proxyOptions so callers that don't have a standard `sites/` layout (eg frappe press dashboard - potentially any caller using frappe-ui as a lib) can configure the `webserver_port`. Also includes basic node test run via `node --test ./vite.test.js`.
bprashanth
force-pushed
the
site_config
branch
from
157aace
to
caf774f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change passes a path to a
site_configintovite.js'sproxyOptionsso callers that don't have a standardsites/layout (eg frappe press dashboard - potentially any caller usingfrappe-uias a lib) can configure thewebserver_port.Also includes basic node test run via
node --test vite.test.js.