Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accomodate common_filters=None in Bank Reco API (backport #2224) #2227

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 24, 2024

Ref: #1510 (comment), alyf-de/banking#108

  1. get_matching_queries and get_ec_matching_query default to common_filters=None but do not handle the case where it is None
  2. The IN Sql Operator does not accept empty lists. If mode_of_payments returns an empty list, the query breaks
    This is an automatic backport of pull request fix: Accomodate common_filters=None in Bank Reco API #2224 done by Mergify.

@ruchamahabal ruchamahabal merged commit 416ddd0 into version-15-hotfix Sep 24, 2024
8 checks passed
@barredterra barredterra deleted the mergify/bp/version-15-hotfix/pr-2224 branch September 24, 2024 11:05
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants