Add Python 3 to test matrix #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix is configured in tox
|
I like to keep the matrix as it is easier to see which version fails. You might want to add the explicit environment instead, see: |
`tox` figures it out automatically from testenv prefix https://tox.wiki/en/latest/config.html#tox-environments
abitrolly
changed the title
|
I added Python 3.10 to the |
This allows to run in generic environments, such as `py39`
tox -e py39
Closed
|
Added |
|
#14 might have some useful things to work from. I only had one problem with that work, see comments. |
`create_*` functions return bytes https://github.com/pydot/pydot/blob/90936e75462c7b0e4bb16d97c1ae7efdf04e895c/src/pydot/core.py#L1685
Convert `bytes` to string before parsing
def parse_graph(graph):
result = {}
> sio = StringIO(graph.create_plain())
E TypeError: initial_value must be str or None, not bytes
|
All Python 3 tests fixed. @fschulze this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Python matrix from actions workflow, because tested Python versions are configured in
tox.ini.