Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple extension members cause additional lines to be printed #473

Closed
Shmew opened this issue Aug 30, 2019 · 2 comments
Closed

Multiple extension members cause additional lines to be printed #473

Shmew opened this issue Aug 30, 2019 · 2 comments

Comments

@Shmew
Copy link

Shmew commented Aug 30, 2019 •
edited
Loading

Description

When using the Trivia branch if there are multiple extension members it will cause an additional line to be added above the member. If formatted again with the output of the first, it will add yet another additional line.

I can't change this behavior with any settings changes except for StrictMode.

Repro code

Start
Running on output
@nojaf
Copy link
Contributor

nojaf commented Aug 30, 2019

I'll have a look at this.
When strict mode is enabled no trivia will be processed, so indeed problems with newlines can't occur over there.

nojaf added a commit that referenced this issue Aug 30, 2019
@nojaf
fix: don't emit additional newlines before attributes of static membe…
25cb23d 
…rs. #473
@nojaf
Copy link
Contributor

nojaf commented Aug 30, 2019

Looks like this is fixed now. Many thanks for reporting these kinds of issues. Keep them coming!

@nojaf nojaf closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nojaf @Shmew