Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetects Buzz device #3

Closed

Conversation

SamDecrock
Copy link
Contributor

The library was unable to find my PS2 (wired) buzzers on my Macbook.

It turned out it used the wrong productId. I suspect the productId is variable.
I therefor created a fork which autodetects the Buzz buttons based on the product name.

@functino
Copy link
Owner

functino commented Jan 5, 2019

Hi @SamDecrock
thanks for your PR.
Do you know which productId/vendorId your buzzers use? If I look up "Buzz" here: https://www.the-sz.com/products/usbid/index.php?v=&p=&n=Buzz I can only find the vendorId/productId I'm already using.

But I agree that it wouldn't hurt changing the detection to use the name.
I'll take a deeper look later and will add commits to make the unit tests turn green again :)

Thanks again for your contribution.

@functino functino mentioned this pull request Jan 5, 2019
@functino
Copy link
Owner

functino commented Jan 5, 2019

Hi @SamDecrock, I've created a follow-up PR that uses your method of connecting as a fallback. What do you think: https://github.com/functino/buzz-buzzers/pull/4/files Looks good?

closed in favor of: #4

@functino functino closed this Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants