tests/benchmarks/bench_sched_yield: initial commit #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
requested changes
Mar 15, 2024
There was a problem hiding this comment.
I'm not a huge fan of mixing tests and benchmarks, Cargo's package layout does separate them. Would it make sense to have a /benches/onboard directory for on-board benchmarks instead (that way we can also have native benchmarks later if needed)?
kaspar030
force-pushed
the
benchmarks
branch
3 times, most recently
from
b99cdc4
to
e74f343
Compare
ROMemories
approved these changes
Mar 26, 2024
ROMemories
requested changes
Mar 26, 2024
ROMemories
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new folder hierarchy
tests/, withtests/benchmarks, and a first benchmark that I probably ad-hoc coded 5 times already.