Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: name the dependency check workflow #215

Merged

Conversation

ROMemories
Copy link
Collaborator

No description provided.

@ROMemories
Copy link
Collaborator Author

ROMemories commented Mar 25, 2024

I think the name hasn't changed in the checks of this PR because the context in which they run is not the same as for pull_requests:

[pull_request_target] runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does.

@kaspar030
Copy link
Collaborator

LGTM. (this probably needs updating the branch protection)

@ROMemories
Copy link
Collaborator Author

this probably needs updating the branch protection

Will add the check to required checks, it doesn't seem to be in the list yet.

@ROMemories ROMemories added this pull request to the merge queue Mar 26, 2024
Merged via the queue into future-proof-iot:main with commit 5b4c0c9 Mar 26, 2024
16 checks passed
@ROMemories ROMemories deleted the ci/rename-dependency-check branch March 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants