FIX an issue about the 'client_port' parameter in RtspServer #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) is optional in RtspServer * If not specified then use the specified RTP port + 1.
KentVu
changed the title
|
@fyhertz please confirm if there are no other similar implications about the port parameter. Since RFC2326 is not forcing the range part as mentioned. |
NoelAlgora
pushed a commit
to ivangulyk/DeviceToDeviceStreamingAndroid
that referenced
this pull request
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RtspServer responds to client's setup request with unexpected client_port parameter, leading some clients unable to play.
I've tried this pull request to ExoPlayer. It didn't work until I fix this in RtspServer. It seems not accepting the server's specified port that's different from its chosen port.