Fix handling of 'podman pod create --share=...' #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously treated
Pod.create(share=[])the same as not passing thesharearg (not passing it to podman), but the podman default is to shareuts,ipcandnetnamespaces. This means there's no way to specify that no namespaces should be shared.In addition, podman expects this list of namespaces to be passed as a single comma-separated arg, e.g.
--share uts,ipc, not in the form--share uts --share ipc(only the last is taken in this case). This means there's another bug where the use of the internalCommand.add_args_iterable()helper method meant only one shared namespace could be specified.It seems possible there could be other related bugs to do with the format of lists on the CLI...