Redesign book detail view #948
Conversation
shows the filename
accidentally commited this sometime, whoops
| @@ -258,7 +258,7 @@ menu book_menu_model { | |||
| section { | |||
| item { | |||
| action: 'book_overview.download'; | |||
| label: _("_Available Offline"); | |||
| label: _("Download Book"); | |||
There was a problem hiding this comment.
This is a two-state action, that's why I went with "Available Offline".
There was a problem hiding this comment.
Thank you for working on this!
I've left a few comments, but the changes are great overall. The horizontal progress bar indeed works better, however there's a reason I added a circular progressbar not so long ago. On mobile view, the long progressbar doesn't really make sense, and the labels would be cut off anyways, so I'd keep the circular one for when the screen is too narrow (ie. on the smallest breakpoint size)
| self.album_art.set_paintable(paintable) | ||
| self.album_art.set_overflow(True) | ||
| self.album_art_container.set_visible_child(self.album_art) | ||
| else: | ||
| self.fallback_icon.set_from_icon_name("book-open-variant-symbolic") |
There was a problem hiding this comment.
This could be set from the Blueprint file
|
@DjLizama please don't approve pull requests without actually reviewing it. Thanks! |
|
Thank you for the review! I think the progress bar works fine on narrower screens, although the rest of the top bar could use a little work.
|
|
Hmm. Maybe it should display times in the |
Should close #945 and #943
This adds a tooltip showing the file name of the chapter when you hover over it, and a fallback image. Also changes out the weird progress ring and labels with a progress bar.
Also gives two lines to the title text, instead of just one. And moves the playbutton to the right hand side.
Here is it without those two changes, I think the 2 lines look better, but not sure on what side the play button should be on
Also adds to the options menu, giving it the same options as in the card + the now renamed download button (greyed out because the option isnt availible, would just be hidden normally)
Should the preview card also have the download option? I think it would make sense if the two menus had all the same options
Going to keep this as a draft untill I get feedback on the design