openapi3: internalize refs for path parameters (#960)

openapi3/internalize_refs.go

@@ -351,7 +351,10 @@ func (doc *T) derefPaths(paths map[string]*PathItem, refNameResolver RefNameReso
 		ops.Ref = ""
 
 		for _, param := range ops.Parameters {
-			doc.addParameterToSpec(param, refNameResolver, pathIsExternal)
+			isExternal := doc.addParameterToSpec(param, refNameResolver, pathIsExternal)
+			if param.Value != nil {
+				doc.derefParameter(*param.Value, refNameResolver, pathIsExternal || isExternal)
+			}
 		}
 
 		for _, op := range ops.Operations() {

openapi3/internalize_refs_test.go

@@ -23,6 +23,7 @@ func TestInternalizeRefs(t *testing.T) {
 		{"testdata/spec.yaml"},
 		{"testdata/callbacks.yml"},
 		{"testdata/issue831/testref.internalizepath.openapi.yml"},
+		{"testdata/issue959/openapi.yml"},
 	}
 
 	for _, test := range tests {

openapi3/testdata/issue959/components.yml

@@ -0,0 +1,4 @@
+components:
+  schemas:
+    External1:
+      type: string

openapi3/testdata/issue959/openapi.yml

@@ -0,0 +1,16 @@
+openapi: 3.0.0
+info:
+  title: foo
+  version: 0.0.0
+paths:
+  /{external1}:
+    parameters:
+      - in: path
+        name: external1
+        required: true
+        schema:
+          $ref: './components.yml#/components/schemas/External1'
+    get:
+      responses:
+        '204':
+          description: No content

openapi3/testdata/issue959/openapi.yml.internalized.yml

@@ -0,0 +1,35 @@
+{
+  "components": {
+    "schemas": {
+      "External1": {
+        "type": "string"
+      }
+    }
+  },
+  "info": {
+    "title": "foo",
+    "version": "0.0.0"
+  },
+  "openapi": "3.0.0",
+  "paths": {
+    "/{external1}": {
+      "get": {
+        "responses": {
+          "204": {
+            "description": "No content"
+          }
+        }
+      },
+      "parameters": [
+        {
+          "in": "path",
+          "name": "external1",
+          "required": true,
+          "schema": {
+            "$ref": "#/components/schemas/External1"
+          }
+        }
+      ]
+    }
+  }
+}