feat(charges): Add regroup_paid_fees to Charge
#2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
force-pushed
the
feat-statement-bool
branch
from
9d8eb43
to
dee3417
Compare
julienbourdeau
changed the title
regroup_paid_fees to Charge
julienbourdeau
force-pushed
the
feat-statement-bool
branch
from
dee3417
to
9034853
Compare
brunomiguelpinto
force-pushed
the
feat-regroup-fees
branch
from
f52a5e9
to
058cbf0
Compare
julienbourdeau
force-pushed
the
feat-statement-bool
branch
from
9034853
to
c7f1035
Compare
julienbourdeau
force-pushed
the
feat-statement-bool
branch
3 times, most recently
from
1e2e109
to
534c89f
Compare
julienbourdeau
force-pushed
the
feat-statement-bool
branch
from
534c89f
to
dd680ea
Compare
brunomiguelpinto
approved these changes
Jul 4, 2024
ancorcruz
pushed a commit
that referenced
this pull request
Jul 7, 2024
When your charge is pay in advance but not invoiceable, the fees are created but not attached to any invoice. This adds an options so at the end of the period, you get a new invoice showing all PAID fees. unpaid fees are ignored. See also #2171 We're dropping the idea of `invoice_strategy` because it turned out to be a bad idea. Instead we're adding `regroup_paid_fees` attribute that takes only one value today `invoice`.
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When your charge is pay in advance but not invoiceable, the fees are created but not attached to any invoice.
This adds an options so at the end of the period, you get a new invoice showing all PAID fees. unpaid fees are ignored.
See also #2171
Description
We're dropping the idea of
invoice_strategybecause it turned out to be a bad idea. Instead we're addingregroup_paid_feesattribute that takes only one value todayinvoice.