Feat: anrok - add error detail to invoice serialization #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
ftr-anrok-graphql-serialize-error-detail
branch
from
03ad076
to
a8af1fd
Compare
annvelents
force-pushed
the
ftr-anrok-create-integration-error-details-service
branch
from
c62c619
to
8318ccc
Compare
annvelents
force-pushed
the
ftr-anrok-graphql-serialize-error-detail
branch
2 times, most recently
from
40a4849
to
4e518d1
Compare
annvelents
force-pushed
the
ftr-anrok-create-integration-error-details-service
branch
from
826e703
to
3154c9e
Compare
annvelents
force-pushed
the
ftr-anrok-graphql-serialize-error-detail
branch
from
74ccbc5
to
9072e0c
Compare
Base automatically changed from
ftr-anrok-create-integration-error-details-service
to
main
July 24, 2024 14:42
annvelents
force-pushed
the
ftr-anrok-graphql-serialize-error-detail
branch
from
62a603d
to
9d7bd8e
Compare
annvelents
force-pushed
the
ftr-anrok-graphql-serialize-error-detail
branch
from
9d7bd8e
to
3d9861b
Compare
annvelents
changed the title
lovrocolic
reviewed
Jul 25, 2024
| graphql_name 'ErrorDetail' | ||
|
|
||
| field :error_code, Types::ErrorDetails::ErrorCodesEnum, null: false | ||
| field :error_details, GraphQL::Types::JSON, null: true |
There was a problem hiding this comment.
What do you think of making it string? It would be easier for FE to fetch it and it follows structure used on other similar places (e.g. netsuite object). If we will have new key in error details, we will just expose it as new field in this object...
There was a problem hiding this comment.
ah, sure!
Was thinking about making it a string, but found Jsons at some places, so thought it's more common to use Jsons 🙈
There was a problem hiding this comment.
yep, we also use JSON somewhere, but in those cases that field is flexible and can have various keys. In our case (until we extend error details) it is just string that is describing error code. If doable, I prefer defining type to avoid errors related to it :D
annvelents
added a commit
that referenced
this pull request
Jul 25, 2024
## Context When adding error_details to the invoices [PR](#2329), we added details of the errors as a jsonb object, while for now we'll be only storing there the error_code / error clarification and FE doesn't need the whole object for this ## Description Updated error_detail type to send only first value of it's detils
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Context As part of implementation logic to store errors received from Anrok through Nango we need to serialize error_details to the FE and API ## Description Added Error Details to serializers ---------
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
…go#2333) ## Context When adding error_details to the invoices [PR](getlago#2329), we added details of the errors as a jsonb object, while for now we'll be only storing there the error_code / error clarification and FE doesn't need the whole object for this ## Description Updated error_detail type to send only first value of it's detils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As part of implementation logic to store errors received from Anrok through Nango we need to serialize error_details to the FE and API
Description
Added Error Details to serializers