feat(invoices): Add open status #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
approved these changes
Jul 24, 2024
julienbourdeau
added a commit
that referenced
this pull request
Jul 29, 2024
…wallet-related models (#2326) ## Description We're introducing a way to topup your wallet without an invoice. The invoice is only generated after the payment is made. Internally, when the wallet transaction is initialized, we'll create [an `open` invoice](#2330), which is invisible and doesn't have a number yet. This invoice can be paid. Once it's paid it's going to be finalized. (see #2336) This PR introduce a parameter to control this behavior. * When a `WalletTransaction` is created, the `invoice_require_successful_payment` attribute can be set explicitly. * If not set, it follows the `Wallet` configuration * When a wallet `RecurringTransactionRule` is created, the `invoice_require_successful_payment` attribute can be set explicitly. * If not set, it follows the `Wallet` configuration * When a `WalletTransaction` is created from a `RecurringTransactionRule`, the invoice_require_successful_payment` is always read from the rule. * All three models default to `false` in the DB
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Description The open status is a technical status just like `generating`. It's used in different upcoming feature. `open` invoices means: * invoice cannot be edited (unlike `draft`) * invoice is not visible (not via API nor GQL) * invoice is payable
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
…wallet-related models (getlago#2326) ## Description We're introducing a way to topup your wallet without an invoice. The invoice is only generated after the payment is made. Internally, when the wallet transaction is initialized, we'll create [an `open` invoice](getlago#2330), which is invisible and doesn't have a number yet. This invoice can be paid. Once it's paid it's going to be finalized. (see getlago#2336) This PR introduce a parameter to control this behavior. * When a `WalletTransaction` is created, the `invoice_require_successful_payment` attribute can be set explicitly. * If not set, it follows the `Wallet` configuration * When a wallet `RecurringTransactionRule` is created, the `invoice_require_successful_payment` attribute can be set explicitly. * If not set, it follows the `Wallet` configuration * When a `WalletTransaction` is created from a `RecurringTransactionRule`, the invoice_require_successful_payment` is always read from the rule. * All three models default to `false` in the DB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The open status is a technical status just like
generating. It's used in different upcoming feature.openinvoices means:draft)