fix: invoices query payment_dispute_lost filter #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever `payment_dispute_lost` filter had a value other than `nil` it was returing only inovoices with `payment_dispute_lost`, hence, when the filter had a `false` value, it still returns only invoices with a payment dispute lost. This change fixes the filter by providing the proper scoping base on the value of the filter.
ancorcruz
force-pushed
the
fix-invoices-query-payment-dispute-lost-filter
branch
from
a3c0c72
to
dcb1096
Compare
ivannovosad
approved these changes
Jul 26, 2024
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Context Whenever `payment_dispute_lost` filter had a value other than `nil` it was returing only inovoices with `payment_dispute_lost`, hence, when the filter had a `false` value, it still returns only invoices with a payment dispute lost. ## Description This change fixes the filter by providing the proper scoping base on the value of the filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Whenever
payment_dispute_lostfilter had a value other thannilit was returing only inovoices withpayment_dispute_lost,hence, when the filter had a
falsevalue, it still returns only invoices with a payment dispute lost.Description
This change fixes the filter by providing the proper scoping base on the value of the filter.