fix: invoices query payment_overdue filter #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Context Given `payment_overdue` filter is false, `InvoicesQuery` ignores the filter and return all invoices without consider their `payment_overdue` value, while it should only return `payment_overdue` == false invoices. # Description This change fixes the filter by providing the proper scoping base on the value of the filter.
rsempe
reviewed
Jul 29, 2024
rsempe
reviewed
Jul 29, 2024
ancorcruz
added a commit
that referenced
this pull request
Jul 29, 2024
This reverts commit a752edb.
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Context Given `payment_overdue` filter is false, `InvoicesQuery` ignores the filter and return all invoices without consider their `payment_overdue` value, while it should only return `payment_overdue` == false invoices. ## Description This change fixes the filter by providing the proper scoping base on the value of the filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Given
payment_overduefilter is false,InvoicesQueryignores the filter and return all invoices without consider theirpayment_overduevalue, while it should only returnpayment_overdue== false invoices.Description
This change fixes the filter by providing the proper scoping base on the value of the filter.